Wikimedia Commons
Android app
Three fixes of mine, merged into the Android app people use to upload photos to Wikimedia Commons, with new tests behind each one.
- Platform
- Open source
- When
- 2026
- Role
- Contributor
- Merged
- 3 pull requests
- Latest
- 2 Nov 2026
- Status
- Three pull requests merged
internal fun NotificationCompat.Builder.useUploadProgressChannel(): NotificationCompat.Builder =
setChannelId(CommonsApplication.NOTIFICATION_CHANNEL_ID_UPLOADS)
.setOnlyAlertOnce(true)
internal fun NotificationCompat.Builder.useUploadResultChannel(): NotificationCompat.Builder =
setChannelId(CommonsApplication.NOTIFICATION_CHANNEL_ID_ALL)
.setOnlyAlertOnce(false)The problem
Someone else’s project has its own rules and maintainers, and years of history. Each of these started from an open issue, and had to fit the code as it is, pass the project’s checks and be easy to review.
What I built
Each change is one pull request for one issue, with the project’s ktlint and Detekt checks passing, new unit tests, and what I tested written out for the maintainers. A maintainer merged all three.
Hard partFinding where a 2019 bug lives now, in code that had been replaced since the first fix.
What it does
- 01
Quieter uploads (#7071)
A bug first reported in 2019: the app made a sound for every file while uploading. Progress now has its own silent channel, and only the result alerts you. Fixes #2528.
- 02
No wasted copies (#7069)
Share a RAW file next to its JPEG and the RAW was copied, then thrown away: 12.6 MB per photo in my test. Unsupported files are now skipped before copying, and the warning still shows. Fixes #6908.
- 03
A smaller achievements screen (#7184)
One class with 27 functions, over the project’s limit, is now the screen and two tested helpers, and it works as it did. Fixes #7156.
Under the hood
- 01An open issueWhat’s wrong, reported by others
- 02Reproduce itOn current main, in an emulator or a test
- 03A small changeWith unit tests and the project’s checks
- 04Review and mergeBy the app’s maintainer
Decisions
- 01
A new silent channel, not a quieter default
The earlier fixes only silenced updates to a notification still showing, but each file posts a new one. A channel of low importance can’t make a sound at all.
Trade-offFinished uploads still alert once. I noted in the pull request that making them silent too is one line.
- 02
Check the file type before copying it
The existing filter ran after the copy. Running the same check on each shared file first means an unsupported one is never copied.
Trade-offThe shared-file path now has its own step, so the old filter stays for files picked inside the app.
Timeline
#7069 merged
Skip unsupported shared files before copying them.
#7184 merged
Split the achievements screen into smaller, tested pieces.
#7071 merged
Post upload progress notifications silently.
Built with
KotlinAndroidRobolectricJUnitktlintDetekt
These are merged into the project’s main code, and reach the store with the app’s own releases.